Fix checking maximum header size, do not take start of body into account #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for filing this PR 👍 Unfortunately it has no tests, see also #82. |
WyriHaximus
requested changes
Feb 5, 2017
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
As @clue mentions could you add tests?
src/Server.php
Outdated
| }); | ||
| $parser->on('error', function($exception) { | ||
| $this->emit('error', [$exception]); | ||
| }); |
Member
There was a problem hiding this comment.
Not sure why this is in this PR? (It does make sense to do this non the less.)
nopolabs
force-pushed
the
fix/header-size-in-RequestHeaderParser
branch
from
5fb8f9e to
c4c1aec
Compare
Contributor
Author
|
added test removed bubble up of error from Server.php, not related to this issue |
Member
Test look good, but now this test is failing
Great, thanks 👍 |
nopolabs
force-pushed
the
fix/header-size-in-RequestHeaderParser
branch
2 times, most recently
from
6e3c57d to
97ac89c
Compare
clue
reviewed
Feb 5, 2017
tests/ServerTest.php
Outdated
|
|
||
| $data = $this->createGetRequest(); | ||
| $data = str_pad($data, 4096 * 4); | ||
| $data = chop($this->createGetRequest()); |
Member
There was a problem hiding this comment.
This looks okay, but could probably be a bit clearer. What do you think, should this be updated to use a literal request string here instead?
Contributor
Author
There was a problem hiding this comment.
I agree, thanks for the suggestion.
nopolabs
force-pushed
the
fix/header-size-in-RequestHeaderParser
branch
from
97ac89c to
5dc78e7
Compare
clue
approved these changes
Feb 6, 2017
clue
changed the title
This was referenced Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed check for exceeding maximum header size in RequestHeaderParser::feed()