Fixes #80 issue: now we support scenario when first buffer exceeds maxSize in RequestHeaderParser #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceeds maxSize in RequestHeaderParser
|
Any movement on this? I had to manually apply this merge to get things working. |
clue
requested changes
Jan 5, 2017
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@nick4fake thanks for the PR, this is much appreciated! 👍
Functionally, your PR looks good to me and I'd love to get this in, but I'll have to vote 👎 for now because it actually addresses multiple things at once. May I ask you to split this up into multiple PRs so we can discuss the individual issues at hand? Thanks!
|
+1 for getting this merged, @clue I personally can't see how this could be split up into multiple PR's |
Member
|
Closed via #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.