Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install uv-extension in v0.2.4 for PHP 7.x in test matrix #268

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

SimonFrings
Copy link
Member

@SimonFrings SimonFrings commented Sep 1, 2023

This pull request updates the test matrix to install the pecl/uv extension in v0.2.4. Previously, we were always installing the latest version of this extension, which caused installation failures for pecl/uv on PHP 7 after the latest release of v0.3.0. This new version is only compatible with PHP 8 and above, I went back to the latest known version that works for PHP 7.

We became aware of this issue after @samsonasik test suite execution failed in #267.

For more reference about pecl/uv versions see: https://pecl.php.net/package/uv
Builds on top of #264.

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! 👍

Agree this can be merged as is, but probably makes sense to look into using uv-0.3.0 on PHP 8+ in a follow-up (refs #264 and #250).

@SimonFrings
Copy link
Member Author

Agree this can be merged as is, but probably makes sense to look into using uv-0.3.0 on PHP 8+ in a follow-up (refs #264 and #250).

@clue Good point, I'll look into this in a follow up PR 👍

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on going with stable instead of beta for PHP 8

@WyriHaximus WyriHaximus merged commit f665998 into reactphp:1.x Sep 4, 2023
29 checks passed
@clue clue added this to the v1.5.0 milestone Sep 4, 2023
@clue
Copy link
Member

clue commented Oct 23, 2023

probably makes sense to look into using uv-0.3.0 on PHP 8+ in a follow-up

Quick update: I've prepared a PR for this and will send an update once PHP 8.3 support has been merged (#269) :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants