Update test suite and report failed assertions #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Feb 28, 2023
SimonFrings
approved these changes
Mar 2, 2023
This was referenced Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates the test suite and makes sure we report any failed assertions as already discussed in reactphp/socket#299 and reactphp/socket#300.
In particular, we now test stable and "unstable" (or legacy) extensions separately (see also #250). Porting the test suite to latest versions was relatively straight forward, but you're also looking at several hours of work to make sure any legacy versions continue to work as is, yey! As discussed in #230, we may get rid of these legacy installations in the future and there's potential to significantly simplify this setup by installing extensions using the respective GitHub action instead (see also future plans for ReactPHP v3 as discussed in https://github.com/orgs/reactphp/discussions/481).
Builds on top of #258, #251, #250, #230, reactphp/socket#299 and reactphp/socket#300