Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated "adding interactivity" page #539

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MinichMykyta
Copy link

No description provided.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
uk-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview May 19, 2024 6:39am

@alinkedd alinkedd self-requested a review May 15, 2024 09:44
@alinkedd alinkedd marked this pull request as draft May 15, 2024 11:08
@alinkedd alinkedd marked this pull request as draft May 15, 2024 11:08
@alinkedd alinkedd marked this pull request as draft May 15, 2024 11:08
@alinkedd
Copy link
Collaborator

Converted to draft based on this comment #457 (comment)

@alinkedd
Copy link
Collaborator

Regarding the PR itself:

  1. Please, shorten the name to Translated "adding interactivity" page or similar.
  2. The Vercel deployment has failed. Usually it happens if page has invalid content that can’t be parsed. Please, run your fork locally as described in README and find out if that’s a case. I suggest to check this line as it’s possible for <button> without `` to be the root cause of failure, though I can’t check this myself right now.
    1. Also it’s just a good practice to run your work locally after translation

Copy link
Collaborator

@alinkedd alinkedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я додала коментарі для частин, які не будуть змінюватися

src/content/learn/adding-interactivity.md Outdated Show resolved Hide resolved
src/content/learn/adding-interactivity.md Outdated Show resolved Hide resolved
src/content/learn/adding-interactivity.md Outdated Show resolved Hide resolved

<Sandpack>

```js
export default function App() {
return (
<Toolbar
onPlayMovie={() => alert('Playing!')}
onUploadImage={() => alert('Uploading!')}
onPlayMovie={() => alert('Грає!')}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переклади прикладів мають співпадати із вже перекладеними розділами. Далі для інших місць треба буде перевірити, коли перекладуть інші частини

src/content/learn/adding-interactivity.md Outdated Show resolved Hide resolved

Or, if you're already familiar with these topics, why not read about [Managing State](/learn/managing-state)?
Або, якщо ви вже знайомі з цими темами, чому б не прочитати про [Управління станом](/learn/managing-state)?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Увесь цей пункт краще перекласти, як той what’s next https://uk.react.dev/learn/describing-the-ui

src/content/learn/adding-interactivity.md Outdated Show resolved Hide resolved
MinichMykyta and others added 5 commits May 17, 2024 13:30
@MinichMykyta MinichMykyta changed the title Translated "adding interactivity" page on the React documentation website. Translated "adding interactivity" page May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants