Remove rackt-cli #98
Closed
Remove rackt-cli #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chentsulin
force-pushed
the
remove-rackt-cli
branch
2 times, most recently
from
abdb0f7 to
32ba711
Compare
chentsulin
force-pushed
the
remove-rackt-cli
branch
from
32ba711 to
c3585c7
Compare
Collaborator
|
I already have a branch locally that is doing the same and uses eslint2 and jest for the tests. I'm gonna merge this branch as soon as all tests pass. And then iterate on the remaining issues. |
Member
Author
|
Is there any reasons or advantages that make we migrate tests from mocha to jest? I think support v15 is our highest priority. |
Collaborator
|
I wanted to have the tests running before starting to fix other stuff, but you are right, that react 15 is now the highest priority. |
Member
Author
|
https://travis-ci.org/reactjs/react-tabs/jobs/134950549 There is already 25 tests run on travis's Firefox via mocha and karma. Are they enough for fix other stuff or they don't cover all testing cases we need? |
Collaborator
|
Done in #100 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project has been moved from rackt to reactjs org, so I think removing
rackt-cliis something that eventually need to be done. And then after merged this, we can move forward to clean up some stuffs and update some dependencies which we care (babel 6, eslint 2, react 15). At this moment, neither react-tabs nor react-simple-tabs support react v15.@timdorr @mzabriskie This PR now pass the tests. webpack, eslint, karma configs and scirpts is copies from react-cli repo, and we can refactor them later.