Rework tests, linting and publishing #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
In my opinion, rackt-cli's release script is too complex, |
Collaborator
Author
|
I think exactly the same, because this library is also not that big, but as the release is still done by @mzabriskie I don't want to break the release flow too much, unless he is fine on simplifying it. The umd build is for bower, I have too check how publish for bower works. Imho I would drop bower, not sure if it is really used, as react-tabs is the only component that I know that has support for bower. |
This was referenced Jun 6, 2016
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chentsulin I also included stuff from your pull request. I hope I copied everything correctly.