This repository has been archived by the owner on Jul 19, 2019. It is now read-only.
Dependency cleanup #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "lodash": "^4.5.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "react": "^0.14.7 || ^15.0.0-0" |
There was a problem hiding this comment.
React.render was removed in version 15 - probably want to update the examples in this PR too.
There was a problem hiding this comment.
Yep, going to do it in a separate PR.
|
Hey, @sprjr! Nice to see that PR merged into master! |
Closed
Having React as a direct dependency can cause multiple versions of React to be bundled in applications that depend on a React version that doesn't match `^0.14.7`.
CMTegner
force-pushed
the
dependency-cleanup
branch
from
fff954b to
9e04b2b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^0.14.7.