Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Commit

Permalink
Dependency cleanup (#94)
Browse files Browse the repository at this point in the history
* [fixed] Remove duplicate dependency

* [fixed] Demote React to a peer dependency

Having React as a direct dependency can cause multiple versions of React
to be bundled in applications that depend on a React version that doesn't
match `^0.14.7`.

* [changed] Allow both 0.14 and 15 versions of React
  • Loading branch information
CMTegner authored and whichsteveyp committed May 26, 2016
1 parent 90d28f1 commit e331ef5
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@
"mocha": "~2.4.5",
"mocha-jsdom": "^1.1.0",
"rackt-cli": "^0.4.0",
"react": "^0.14.0",
"react-addons-test-utils": "^0.14.7"
"react": "^0.14.7",
"react-addons-test-utils": "^0.14.7",
"react-dom": "^0.14.7"
},
"tags": [
"react",
Expand All @@ -46,9 +47,9 @@
],
"keywords": [],
"dependencies": {
"babel-preset-es2015": "^6.5.0",
"dom-scroll-into-view": "1.0.1",
"react": "^0.14.7",
"react-dom": "^0.14.7"
"dom-scroll-into-view": "1.0.1"
},
"peerDependencies": {
"react": "^0.14.7 || ^15.0.0-0"
}
}

3 comments on commit e331ef5

@blackrabbit99
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do you plan to publish this change?

@whichsteveyp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blackrabbit99 this should be available in 1.0.0-rc4 published just now, until the other items from #109 are wrapped up. Hope that helps!

@blackrabbit99
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sprjr Finally! I'll remove commit from dependecy

Please sign in to comment.