pkg: Relax @babel/runtime requirement to ^7.7.2 #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -44 B (0%) Total Size: 109 kB
ℹ️ View Unchanged
|
ntucker
force-pushed
the
pkg/babel-runtime
branch
from
e7009e9
to
3f87be7
Compare
2 tasks
ljharb
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having multiple @babel/runtimes with nesting creates some interesting issues when building.
After a more thorough investigation of babel/babel#10853 I have realized that 7.12 is simply the requirement to work with webpack 5, but interop with babel/core will work. This is due to the new package exports directives - which are processed by webpack 5 only.
Thus, users of webpack 5, should ensure they run only babel 7.12+ and also hoist it to ensure a single version. Other users should not care.
Solution
To reduce the chance of non-hoisted runtimes, we relax our requirements to what 4.5.9 was. This should enable no new introduced of non-hoisted runtimes.