Skip to content

Make it compatible with RN 0.60.0 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Make it compatible with RN 0.60.0 #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RNVoipPushNotification.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ Pod::Spec.new do |s|
s.requires_arc = true
s.platform = :ios, "8.0"
s.source_files = "ios/RNVoipPushNotification/*.{h,m}"
s.dependency 'React/Core'
s.dependency 'React-Core'
Copy link
Member

@zxcpoiu zxcpoiu Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's a breaking change, could you test if works for you if you change it

from:
s.dependency 'React-Core'
to
s.dependency 'React'
?

Copy link

@ThomasLarge ThomasLarge Sep 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it works with both but it looks like other packages us s.dependency 'React' as I think it's backwards compatible

end