Make it compatible with RN 0.60.0 #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnunley
approved these changes
Jul 23, 2019
|
Hi, does this a breaking change? I mean, after this merged, can user still use this plugin in 0.59 and below? |
|
@zxcpoiu Actually I'm not sure about that, it would be great if you could test that and let us know. |
zxcpoiu
reviewed
Jul 25, 2019
| s.platform = :ios, "8.0" | ||
| s.source_files = "ios/RNVoipPushNotification/*.{h,m}" | ||
| s.dependency 'React/Core' | ||
| s.dependency 'React-Core' |
There was a problem hiding this comment.
Seems like it's a breaking change, could you test if works for you if you change it
from:
s.dependency 'React-Core'
to
s.dependency 'React'
?
There was a problem hiding this comment.
I can confirm it works with both but it looks like other packages us s.dependency 'React' as I think it's backwards compatible
zxcpoiu
added a commit
to zxcpoiu/react-native-voip-push-notification
that referenced
this pull request
Dec 27, 2019
a36c520 readme: update example for new api ( zxcpoiu 2019-12-28 00:13:52 +0800) fe1f6c7 separate requestPermissions and registerVoipToken (react-native-webrtc#40) ( Tuan Luong 2019-12-27 23:05:10 +0700) d129f9c Update React-Core dependency (react-native-webrtc#37) ( Raees Iqbal 2019-12-27 21:04:51 +0500)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.