Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: support name prop (#574)" #575

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

Wxh16144
Copy link
Contributor

@Wxh16144 Wxh16144 commented Aug 30, 2024

  1. This reverts commit d94d644.
  2. add unit test

Summary by CodeRabbit

  • 新功能

    • Upload 组件中添加了默认的文件输入名称属性,便于与后端服务集成。
  • Bug 修复

    • 移除了 AjaxUploader 组件中的 name 属性,可能影响文件上传的处理。
  • 测试

    • 更新了测试用例,删除了对 name 属性的验证,并添加了对文件处理逻辑的验证。

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
upload ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 9:27am

Copy link

coderabbitai bot commented Aug 30, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此次更改涉及AjaxUploaderUpload组件的属性调整,移除了AjaxUploader中的name属性,同时在Upload组件中新增了name属性。测试文件也进行了相应的更新,删除了对name属性的测试,并增加了对文件处理逻辑的验证。

Changes

文件 更改摘要
src/AjaxUploader.tsx 移除AjaxUploader组件的name属性。
src/Upload.tsx Upload类中新增name属性,值为'file'
tests/uploader.spec.tsx 删除测试用例,取消对Upload组件name属性的验证,新增测试用例以验证文件处理逻辑。

Poem

🐰 在草地上跳跃的兔子,
文件上传新变化,
名字轻轻飘散去,
但新名却更欢快。
兔子欢呼声不断,
文件处理更顺畅!
🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (d3cdcb0) to head (c90d091).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files           6        6           
  Lines         278      278           
  Branches       74       73    -1     
=======================================
  Hits          247      247           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 99cdc3e into react-component:master Aug 30, 2024
8 checks passed
@Wxh16144
Copy link
Contributor Author

Wxh16144 commented Aug 30, 2024

说明: #574 在修复 antd 侧(ant-design/ant-design#50643 )问题时,删除了 name 默认值 file。但是这个值是在默认 action 的时候传递给后端的 filename 使用的。不应该删除。 解决 50643 问题得重新考虑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants