-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support name
prop
#574
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough此次更改涉及 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
=======================================
Coverage 88.84% 88.84%
=======================================
Files 6 6
Lines 278 278
Branches 73 76 +3
=======================================
Hits 247 247
Misses 31 31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/AjaxUploader.tsx (2 hunks)
- src/Upload.tsx (1 hunks)
- tests/uploader.spec.tsx (1 hunks)
Additional comments not posted (4)
src/Upload.tsx (1)
Line range hint
10-24
: 验证删除name
属性的影响删除
name
属性可能会影响组件与外部系统或API的交互,特别是那些在上传过程中期望特定文件名的系统。请确保所有依赖于
name
属性的功能都已正确更新,并且没有破坏性的更改。src/AjaxUploader.tsx (2)
Line range hint
1-272
: 添加name
属性添加
name
属性增强了组件的功能,使得文件输入元素可以指定名称属性。代码更改已批准。
311-311
: 集成name
属性将
name
属性集成到渲染的输入元素中,确保在使用组件时正确设置name
属性。代码更改已批准。
tests/uploader.spec.tsx (1)
155-159
: 添加name
属性的测试用例新测试用例确保
name
属性正确分配给渲染的输入元素。代码更改已批准。
antd 仓库需要更新快照。 |
This reverts commit d94d644.
(cherry picked from commit d94d644)
background: ant-design/ant-design#50643
Summary by CodeRabbit
AjaxUploader
组件中添加了name
属性,以增强文件输入的可识别性和表单提交的功能。Upload
组件中的name
属性的默认状态初始化,提升了文件上传的灵活性。uploader
测试套件中新增测试用例,验证Upload
组件是否正确处理name
属性。