Skip to content

fix: long label panel position abnormal #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 6 commits into from
Apr 9, 2024
Merged

fix: long label panel position abnormal #473

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c6b29f
fix: long label panel position abnormal
wanpan11 Mar 11, 2024
23767d9
fix: optimized reset activeValueCells logic
wanpan11 Mar 12, 2024
7929d55
fix: optimized reset logic
wanpan11 Mar 29, 2024
652ee33
Merge branch 'react-component:master' into master
wanpan11 Apr 7, 2024
8f214e5
fix: Simplify the logic
wanpan11 Apr 7, 2024
4703b04
test: add test case
zombieJ Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/OptionList/useActive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,29 @@ export default (
const { values } = React.useContext(CascaderContext);

const firstValueCells = values[0];
const lastValuesRef = React.useRef(null);

// Record current dropdown active options
// This also control the open status
const [activeValueCells, setActiveValueCells] = React.useState<React.Key[]>([]);

React.useEffect(
() => {
if (open && !multiple) {
// use useLayoutEffect timely update of DOM calculation position and Prevent flickering
React.useLayoutEffect(() => {
if (open && !multiple) {
// firstValueCells clear use delay update
if (lastValuesRef.current && !firstValueCells) {
setTimeout(() => {
Comment thread
wanpan11 marked this conversation as resolved.
Outdated
setActiveValueCells([]);
}, 0);
} else {
setActiveValueCells(firstValueCells || []);
}
},
/* eslint-disable react-hooks/exhaustive-deps */
[open, firstValueCells],
/* eslint-enable react-hooks/exhaustive-deps */
);
}

lastValuesRef.current = firstValueCells;

// eslint-disable-next-line react-hooks/exhaustive-deps
}, [open, firstValueCells]);

return [activeValueCells, setActiveValueCells];
};