Skip to content

fix: long label panel position abnormal - #473

Merged
zombieJ merged 6 commits into
react-component:masterfrom
wanpan11:master
Apr 9, 2024
Merged

fix: long label panel position abnormal#473
zombieJ merged 6 commits into
react-component:masterfrom
wanpan11:master

Conversation

@wanpan11

Copy link
Copy Markdown
Contributor

修复 open=true 时 setActiveValueCells 执行时机,避免 pannel 更新不及时造成的定位计算错误
#ant-design/ant-design#47635

202403121302.mp4

@vercel

vercel Bot commented Mar 12, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cascader ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 2:58pm

@codecov

codecov Bot commented Mar 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (fab1188) to head (652ee33).

❗ Current head 652ee33 differs from pull request most recent head 4703b04. Consider uploading reports for the commit 4703b04 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          23       23           
  Lines         604      604           
  Branches      182      182           
=======================================
  Hits          602      602           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/OptionList/useActive.ts Outdated
@afc163

afc163 commented Mar 29, 2024

Copy link
Copy Markdown
Member

改完后是什么效果?

@wanpan11

Copy link
Copy Markdown
Contributor Author

改完后是什么效果?

现在不会出现 panel 定位异常的问题

202403291825.mp4

@afc163

afc163 commented Mar 29, 2024

Copy link
Copy Markdown
Member

是说闪的那一下的问题么?

@wanpan11

wanpan11 commented Mar 29, 2024

Copy link
Copy Markdown
Contributor Author

是说闪的那一下的问题么?

目前在点击选项卡 但是未选中结果取消后 的第二次显示时 panel 出现的位置不正确(open=false 时没有重置路径值导致)

default.mp4

Comment thread src/OptionList/useActive.ts Outdated
@wanpan11

wanpan11 commented Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

multiple 限制会导致这个问题 记录一下
ant-design/ant-design#48208

Comment thread tests/selector.spec.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants