Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make slack.Notifier public #373

Merged
merged 2 commits into from
Mar 7, 2023
Merged

refactor: make slack.Notifier public #373

merged 2 commits into from
Mar 7, 2023

Conversation

bsushmith
Copy link
Member

  • make slack.Notifier public

Changes for discussion - #370 (comment)

@bsushmith
refactor: make slack.Notifier public
8907769 
* make `slack.Notifier` public
@coveralls
Copy link

coveralls commented Mar 7, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4352351092

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 75.029%
Files with Coverage Reduction New Missed Lines %
plugins/notifiers/slack/client.go 4 70.83%
Totals Coverage Status
Change from base Build 4340532339: 0.07%
Covered Lines: 7806
Relevant Lines: 10404
💛 - Coveralls

rahmatrhd
rahmatrhd requested changes Mar 7, 2023
View reviewed changes
@bsushmith bsushmith requested a review from rahmatrhd March 7, 2023 08:59
@bsushmith bsushmith merged commit 8937f4a into main Mar 7, 2023
@bsushmith bsushmith deleted the slack-test-package branch March 7, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd rahmatrhd approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsushmith @coveralls @rahmatrhd