Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update slack notification by adding block functionality to template #370

Merged
merged 10 commits into from
Mar 6, 2023

Conversation

utsav14nov
Copy link
Contributor

feat: update slack notification by adding block functionality to template

@coveralls
Copy link

coveralls commented Feb 24, 2023

Pull Request Test Coverage Report for Build 4339427071

  • 33 of 51 (64.71%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 74.962%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/notifiers/slack/client.go 26 44 59.09%
Totals Coverage Status
Change from base Build 4249606976: -0.1%
Covered Lines: 7799
Relevant Lines: 10404

💛 - Coveralls

@utsav14nov utsav14nov linked an issue Feb 24, 2023 that may be closed by this pull request
@utsav14nov
Copy link
Contributor Author

@rahmatrhd As checked in terraform, we are be able to read full content from a json file as string and use it as variable in config which makes easily maintainable and structured code in production.
And as you suggested we can add the default config as separate json in guardian and read it programmatically through code.
What say? @bsushmith @haveiss

@bsushmith
Copy link
Member

@utsav14nov Yes. That is fine from a deployment using terraform. But for other kinds of deployment, @rahmatrhd's comment still stands true.
But then again, it should be fine, as long as the user is able to maintain these big strings on their end irrespective of deployment method.

@singhvikash11
Copy link
Member

singhvikash11 commented Feb 27, 2023

@rahmatrhd please have a look of pr #330

@utsav14nov utsav14nov requested a review from haveiss March 1, 2023 11:04
@utsav14nov utsav14nov requested review from rahmatrhd and haveiss March 6, 2023 02:57
@bsushmith bsushmith merged commit aa29ea8 into main Mar 6, 2023
@bsushmith bsushmith deleted the slack_notification_enhancement branch March 6, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guardian Approval through Slack
6 participants