[core] Add more missing implementations to SDL #3439
Conversation
Add functions: `SetWindowState`, `ClearWindowState`, `SetWindowIcon`
|
Uh wait, I'm still going to put tracelogs for the unmanaged flags |
|
It's good, the I've also added VSync support. |
| if (flags & FLAG_BORDERLESS_WINDOWED_MODE) | ||
| { | ||
| // NOTE: Same as FLAG_WINDOW_UNDECORATED with SDL ? | ||
| SDL_SetWindowBordered(platform.window, SDL_FALSE); |
There was a problem hiding this comment.
@Bigfoot71 Could you replace it with ToggleBorderlessWindowed()? This state has a bit more going on (L200-L272) behind the scene.
There was a problem hiding this comment.
@ubkp If I understand correctly what the code in rcore_desktop.c does with GLFW, wouldn’t this parameter be enough SDL_WINDOW_FULLSCREEN_DESKTOP in SDL? (doc)
Or should we do exactly the same thing, i.e. remove the decoration and define the size of the window with that of the screen?
There was a problem hiding this comment.
Or should we do exactly the same thing,
@Bigfoot71 I think we should.
Unfortunately SDL_SetWindowBordered just removes the window decoration.
FLAG_BORDERLESS_WINDOWED_MODE through ToggleBorderlessWindowed does quite a lot of handling (L200-L272). E.g.: leaves real fullscreen if present, saves window pos/sizes (for toggling), removes the decoration, sets it top most, resize it to match the fullscreen and reposition it on the correct monitor. Which is necessary to simulate a fullscreen desktop (which although "present" on SDL, is still a different thing because SDL's fullscreen desktop will still cause the window to get minimized when alt tabbing).
There was a problem hiding this comment.
Thanks! I do that!
There was a problem hiding this comment.
@Bigfoot71 If you want (and have the time), feel free to take ToggleBorderlessWindowed. Note: it probably could be done at the same time with ToggleFullscreen, SetWindowMonitor and GetMonitorPosition since they share a lot of the same handling. Just let me know. 👍
There was a problem hiding this comment.
@ubkp If you, or anyone else, can try it on their system, to see if you have the same problem as with the taskbar which remains in front of the window with ToggleBordelessWindowed that would be cool. Bigfoot71@232a061
There was a problem hiding this comment.
@Bigfoot71 Tested it right now on Fluxbox (X11) and MATE (X11) on Linux Mint 21.1 64-bit and it's working great! Very good job! 👍
I'll spin a Fedora 38 64-bit here to test it on Gnome and KDE with Wayland (may take me an hour to report back tho).
Are you on Cinnamon (X11)?
There was a problem hiding this comment.
@ubkp Yes, I'm on Cinnamon, so it's probably related to that
There was a problem hiding this comment.
@ubkp I have finished implementing the functions you mentioned to me. However, I only have one screen, so I believe (by deduction) that the implementation of 'SetWindowMonitor' should be correct, but I have no idea if it works, and furthermore, it is incomplete.
So, if you or someone else could try and correct this function, it would be great! (Bigfoot71@db0674c)
There was a problem hiding this comment.
@Bigfoot71 SetWindowMonitor has a bit more handling (L615-L643). But don't worry about it, I'll finish it up. Thanks so much for all the work! 👍
ghost
mentioned this pull request
We now get the size of the monitor where the window is located
NOTE: The function is implemented but incomplete
Fixed a delta retrieval issue with `GetMouseDelta` when the mouse is in relative mode. Solution by @ubkp
An issue caused `IsKeyPressed` to continuously return true for most keys when pressed
|
@Bigfoot71 @ubkp Wow! Amazing work! Thank you very much! 👍🙂 |
As requested in #3313 here is the implementation of the
SetWindowState,ClearWindowState, andSetWindowIconfunctions forrcore_desktop_sdl.c.The functions
SetWindowStateandClearWindowStatedon't handle all flags, but it seems that some things can't be managed directly through SDL. Please take a look at the notes in the comments.Otherwise,
SetWindowIconseems to work fine on my end on Cinnamon (Linux Mint). I don't have access to Windows to test it right now.I'm sharing this work now so that if you have any feedback, I can make corrections, or you can merge it directly if everything looks good.