Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SetGamepadMappings returning #3438

Closed
wants to merge 1 commit into from
Closed

Fix SetGamepadMappings returning #3438

wants to merge 1 commit into from

Conversation

Bigfoot71
Copy link
Contributor

@Bigfoot71 Bigfoot71 commented Oct 18, 2023 •
edited
Loading

I fixed the return of SetGamepadMappings which returned nothing. The function now returns SDL_GameControllerAddMapping which returns this information according to the documentation:

returns 1 if a new mapping is added, 0 if an existing mapping is updated,
-1 on error; call SDL_GetError() for more information.

@Bigfoot71 Bigfoot71 changed the title Fix GamepadMappings returning Fix SetGamepadMappings returning Oct 18, 2023
@ghost
Copy link

ghost commented Oct 18, 2023

@Bigfoot71 Good catch!

@Bigfoot71
Copy link
Contributor Author

I move this into #3439

@Bigfoot71 Bigfoot71 closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bigfoot71