Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking ray.get/wait inside async context will warn instead of error #7262

Merged
merged 5 commits into from
Mar 15, 2020
Merged

Blocking ray.get/wait inside async context will warn instead of error #7262

merged 5 commits into from
Mar 15, 2020

Conversation

simon-mo
Copy link
Contributor

Resolve #7197

@simon-mo simon-mo requested a review from edoakes February 21, 2020 19:48
@simon-mo simon-mo mentioned this pull request Feb 21, 2020
Closed
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22258/
Test PASSed.

edoakes
edoakes approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/ray/worker.py Outdated Show resolved Hide resolved
python/ray/worker.py Outdated Show resolved Hide resolved
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22263/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/22568/
Test FAILed.

@simon-mo simon-mo merged commit 3f1fcaa into ray-project:master Mar 15, 2020
@dayshah dayshah mentioned this pull request Feb 12, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot call ray.get inside async actor (not a request for async get)
3 participants
@simon-mo @AmplabJenkins @edoakes