Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add internal __async_ray_call__ for actors #50432

Closed
wants to merge 2 commits into from

Conversation

dayshah
Copy link
Contributor

@dayshah dayshah commented Feb 11, 2025

Why are these changes needed?

If we want to hijack actors to call async functions on them, we need this utility.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: dayshah <[email protected]>
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a tiny integration test to avoid this getting removed/broken

@dayshah dayshah added the go add ONLY when ready to merge, run all tests label Feb 11, 2025
Signed-off-by: dayshah <[email protected]>
@edoakes edoakes enabled auto-merge (squash) February 12, 2025 00:52
@dayshah
Copy link
Contributor Author

dayshah commented Feb 12, 2025

can't do this because of #7262

@dayshah dayshah closed this Feb 12, 2025
auto-merge was automatically disabled February 12, 2025 18:20

Pull request was closed

@dayshah dayshah deleted the async_ray_call branch February 12, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants