Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .buildkite/test.rules.test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,15 @@ python/setup.py: ml tune train serve workflow data python dashboard linux_wheels
python/requirements/test-requirements.txt: ml tune train serve workflow data python dashboard linux_wheels macos_wheels java python_dependencies min_build
python/_raylet.pyx: ml tune train data python dashboard linux_wheels macos_wheels java

# === Raydepsets lock files ===
# macos_depset lock is consumed by the mac smoke test, so it must emit macos_wheels.
python/deplocks/ci/macos_depset_py3.10.lock: macos_wheels
# Other deplock updates should NOT trigger the mac smoke test (no macos_wheels).
python/deplocks/base_deps/ray_base_deps_py3.10.lock: ml tune train data python dashboard linux_wheels java
python/deplocks/ci/data-base-ci_depset_py3.10.lock: ml tune train data python dashboard linux_wheels java

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the test assertions to match the expanded set of tags for general lock file updates, maintaining consistency with the python/setup.py and python/requirements/ test cases.

python/deplocks/base_deps/ray_base_deps_py3.10.lock: ml tune train serve workflow data python dashboard linux_wheels java python_dependencies min_build
python/deplocks/ci/data-base-ci_depset_py3.10.lock: ml tune train serve workflow data python dashboard linux_wheels java python_dependencies min_build

# LLM deplocks still hit the earlier llm rule block.
python/deplocks/llm/ray_py311_cpu.lock: llm

# === Buildkite Configs ===

.buildkite/ml.rayci.yml: ml train train_gpu tune
Expand Down
16 changes: 16 additions & 0 deletions .buildkite/test.rules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,22 @@ python/ray/dashboard/
@ dashboard linux_wheels python
;

# The macOS smoke test installs this specific lock file
# (ci/ray_ci/macos/macos_ci.sh), so changes here must still trigger
# macos_wheels. Must precede the general python/deplocks/ rule below.
python/deplocks/ci/macos_depset_py*
@ macos_wheels
;

# Raydepsets-generated lock files. These do NOT affect the macOS smoke
# test (which only consumes macos_depset_py*, handled above), so we
# deliberately omit macos_wheels here to avoid running mac tests on
# unrelated lock updates.
python/deplocks/
@ ml tune train data
@ python dashboard linux_wheels java
;
Comment on lines +100 to +104

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The python/deplocks/ rule should ideally align with the python/requirements/ rule (lines 107-111) rather than the python/ catch-all. Since lock files are the pinned versions of requirements, changes to them should trigger the same set of tests, including serve, workflow, min_build, and python_dependencies. This ensures that dependency updates are verified across all major components that depend on the base environment.

python/deplocks/
@ ml tune train serve workflow data min_build
@ python dashboard linux_wheels java
@ python_dependencies
;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good idea?


python/setup.py
python/requirements.txt
python/requirements_compiled.txt
Expand Down
Loading