Skip to content

[ci] Skip mac smoke test on raydepsets lock updates except macos_depset#62640

Merged
elliot-barn merged 2 commits into
masterfrom
elliot-barn-macos-build-test-rules-update
Apr 16, 2026
Merged

[ci] Skip mac smoke test on raydepsets lock updates except macos_depset#62640
elliot-barn merged 2 commits into
masterfrom
elliot-barn-macos-build-test-rules-update

Conversation

@elliot-barn

Copy link
Copy Markdown
Collaborator

Summary

  • Stop running the mac: smoke test job (and other macos_wheels-tagged jobs) on raydepsets lock-file updates under python/deplocks/, since those locks don't affect the macOS build path.
  • Keep the mac smoke test running when python/deplocks/ci/macos_depset_py*.lock changes -- ci/ray_ci/macos/macos_ci.sh:136 installs that exact lock, so it's the one raydepsets output that actually matters for mac CI.

Changes

  • .buildkite/test.rules.txt: two new rules before the python/setup.py block.
    • Specific: python/deplocks/ci/macos_depset_py* → macos_wheels
    • General: python/deplocks/ → ml tune train data python dashboard linux_wheels java (mirrors the python/ catchall minus macos_wheels)
  • .buildkite/test.rules.test.txt: new assertions covering macos_depset, two generic deplocks (base_deps + data-base-ci), and an LLM deplock (to confirm the earlier llm rule still wins first-match).

Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Buildkite test rules to refine how dependency lock file changes trigger CI tests, specifically separating macOS smoke tests from general lock file updates to avoid unnecessary test runs. The review suggests expanding the test coverage for general lock file updates to include 'serve', 'workflow', 'min_build', and 'python_dependencies' to ensure consistency with other dependency-related rules.

Comment thread .buildkite/test.rules.txt
Comment on lines +99 to +102
python/deplocks/
@ ml tune train data
@ python dashboard linux_wheels java
;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The python/deplocks/ rule should ideally align with the python/requirements/ rule (lines 107-111) rather than the python/ catch-all. Since lock files are the pinned versions of requirements, changes to them should trigger the same set of tests, including serve, workflow, min_build, and python_dependencies. This ensures that dependency updates are verified across all major components that depend on the base environment.

python/deplocks/
@ ml tune train serve workflow data min_build
@ python dashboard linux_wheels java
@ python_dependencies
;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good idea?

Comment thread .buildkite/test.rules.test.txt Outdated
Comment on lines +42 to +43
python/deplocks/base_deps/ray_base_deps_py3.10.lock: ml tune train data python dashboard linux_wheels java
python/deplocks/ci/data-base-ci_depset_py3.10.lock: ml tune train data python dashboard linux_wheels java

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the test assertions to match the expanded set of tags for general lock file updates, maintaining consistency with the python/setup.py and python/requirements/ test cases.

python/deplocks/base_deps/ray_base_deps_py3.10.lock: ml tune train serve workflow data python dashboard linux_wheels java python_dependencies min_build
python/deplocks/ci/data-base-ci_depset_py3.10.lock: ml tune train serve workflow data python dashboard linux_wheels java python_dependencies min_build

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Apr 15, 2026
@ray-gardener ray-gardener Bot added core Issues that should be addressed in Ray Core devprod labels Apr 15, 2026
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
@elliot-barn elliot-barn merged commit c27136f into master Apr 16, 2026
6 checks passed
@elliot-barn elliot-barn deleted the elliot-barn-macos-build-test-rules-update branch April 16, 2026 02:15
HLDKNotFound pushed a commit to chichic21039/ray that referenced this pull request Apr 22, 2026
…et (ray-project#62640)

**Summary**

- Stop running the mac: smoke test job (and other macos_wheels-tagged
jobs) on raydepsets lock-file updates under python/deplocks/, since
those locks don't affect the macOS build path.
- Keep the mac smoke test running when
python/deplocks/ci/macos_depset_py*.lock changes --
ci/ray_ci/macos/macos_ci.sh:136 installs that exact lock, so it's the
one raydepsets output that actually matters for mac CI.

  **Changes**
- .buildkite/test.rules.txt: two new rules before the python/setup.py
block.
    - Specific: python/deplocks/ci/macos_depset_py* → macos_wheels
- General: python/deplocks/ → ml tune train data python dashboard
linux_wheels java (mirrors the python/ catchall minus macos_wheels)
- .buildkite/test.rules.test.txt: new assertions covering macos_depset,
two generic deplocks (base_deps + data-base-ci), and an LLM deplock (to
confirm the earlier llm rule still wins first-match).

---------

Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Lucas61000 pushed a commit to Lucas61000/ray that referenced this pull request May 15, 2026
…et (ray-project#62640)

**Summary**

- Stop running the mac: smoke test job (and other macos_wheels-tagged
jobs) on raydepsets lock-file updates under python/deplocks/, since
those locks don't affect the macOS build path.
- Keep the mac smoke test running when
python/deplocks/ci/macos_depset_py*.lock changes --
ci/ray_ci/macos/macos_ci.sh:136 installs that exact lock, so it's the
one raydepsets output that actually matters for mac CI.

  **Changes**
- .buildkite/test.rules.txt: two new rules before the python/setup.py
block.
    - Specific: python/deplocks/ci/macos_depset_py* → macos_wheels
- General: python/deplocks/ → ml tune train data python dashboard
linux_wheels java (mirrors the python/ catchall minus macos_wheels)
- .buildkite/test.rules.test.txt: new assertions covering macos_depset,
two generic deplocks (base_deps + data-base-ci), and an LLM deplock (to
confirm the earlier llm rule still wins first-match).

---------

Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core devprod go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants