[ci] Skip mac smoke test on raydepsets lock updates except macos_depset#62640
Conversation
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request updates the Buildkite test rules to refine how dependency lock file changes trigger CI tests, specifically separating macOS smoke tests from general lock file updates to avoid unnecessary test runs. The review suggests expanding the test coverage for general lock file updates to include 'serve', 'workflow', 'min_build', and 'python_dependencies' to ensure consistency with other dependency-related rules.
| python/deplocks/ | ||
| @ ml tune train data | ||
| @ python dashboard linux_wheels java | ||
| ; |
There was a problem hiding this comment.
The python/deplocks/ rule should ideally align with the python/requirements/ rule (lines 107-111) rather than the python/ catch-all. Since lock files are the pinned versions of requirements, changes to them should trigger the same set of tests, including serve, workflow, min_build, and python_dependencies. This ensures that dependency updates are verified across all major components that depend on the base environment.
python/deplocks/
@ ml tune train serve workflow data min_build
@ python dashboard linux_wheels java
@ python_dependencies
;
| python/deplocks/base_deps/ray_base_deps_py3.10.lock: ml tune train data python dashboard linux_wheels java | ||
| python/deplocks/ci/data-base-ci_depset_py3.10.lock: ml tune train data python dashboard linux_wheels java |
There was a problem hiding this comment.
Update the test assertions to match the expanded set of tags for general lock file updates, maintaining consistency with the python/setup.py and python/requirements/ test cases.
python/deplocks/base_deps/ray_base_deps_py3.10.lock: ml tune train serve workflow data python dashboard linux_wheels java python_dependencies min_build
python/deplocks/ci/data-base-ci_depset_py3.10.lock: ml tune train serve workflow data python dashboard linux_wheels java python_dependencies min_build
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
…et (ray-project#62640) **Summary** - Stop running the mac: smoke test job (and other macos_wheels-tagged jobs) on raydepsets lock-file updates under python/deplocks/, since those locks don't affect the macOS build path. - Keep the mac smoke test running when python/deplocks/ci/macos_depset_py*.lock changes -- ci/ray_ci/macos/macos_ci.sh:136 installs that exact lock, so it's the one raydepsets output that actually matters for mac CI. **Changes** - .buildkite/test.rules.txt: two new rules before the python/setup.py block. - Specific: python/deplocks/ci/macos_depset_py* → macos_wheels - General: python/deplocks/ → ml tune train data python dashboard linux_wheels java (mirrors the python/ catchall minus macos_wheels) - .buildkite/test.rules.test.txt: new assertions covering macos_depset, two generic deplocks (base_deps + data-base-ci), and an LLM deplock (to confirm the earlier llm rule still wins first-match). --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
…et (ray-project#62640) **Summary** - Stop running the mac: smoke test job (and other macos_wheels-tagged jobs) on raydepsets lock-file updates under python/deplocks/, since those locks don't affect the macOS build path. - Keep the mac smoke test running when python/deplocks/ci/macos_depset_py*.lock changes -- ci/ray_ci/macos/macos_ci.sh:136 installs that exact lock, so it's the one raydepsets output that actually matters for mac CI. **Changes** - .buildkite/test.rules.txt: two new rules before the python/setup.py block. - Specific: python/deplocks/ci/macos_depset_py* → macos_wheels - General: python/deplocks/ → ml tune train data python dashboard linux_wheels java (mirrors the python/ catchall minus macos_wheels) - .buildkite/test.rules.test.txt: new assertions covering macos_depset, two generic deplocks (base_deps + data-base-ci), and an LLM deplock (to confirm the earlier llm rule still wins first-match). --------- Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Summary
Changes