Revert "[Data] - Add _source_paths to filedatasources (#57574)" #59999
+1
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 460bce4.
Description
This PR likely reintroducing the issue that A previous PR trying to solve: #55978
Specifically, this add a full list of paths to
selfand for FileBaseDatasource self is captured every read_task_fn during serialization and causing this data being duplicated and cause excessive spilling.We face the similar warning and have spilling behavior:
Related issues
#55978
Additional information