Skip to content

pinning docker api version #59047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elliot-barn wants to merge 3 commits into from
Closed

pinning docker api version #59047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8fdb86
pinning docker api version
elliot-barn Nov 27, 2025
97f6ec1
outputting docker version on base test image
elliot-barn Nov 27, 2025
9ab0636
outputing docker version
elliot-barn Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildkite/cicd.rayci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ steps:
--cache-test-results --parallelism-per-worker 2
--build-name oss-ci-base_test-py3.10
--build-type skip
- docker version
Copy link

@cursor cursor bot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Debug command accidentally committed to CI configuration

The docker version command appears to be debugging code left over from investigating the Docker API version issue. It's only added to the "reef-tests" job and not to other similar jobs in the file, and it doesn't contribute to the actual fix (which is the DOCKER_API_VERSION environment variable in the Dockerfile). This was likely used during development to verify Docker configuration and inadvertently included in the PR.

Fix in Cursor Fix in Web

instance_type: small
depends_on:
- oss-ci-base_test-multipy
Expand Down
2 changes: 1 addition & 1 deletion ci/docker/base.test.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ ENV RAY_USE_RANDOM_PORTS=1
ENV RAY_DEFAULT_BUILD=1
ENV RAY_INSTALL_JAVA=0
ENV BUILDKITE_BAZEL_CACHE_URL=${BUILDKITE_BAZEL_CACHE_URL}

ENV DOCKER_API_VERSION=1.43
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability, it's good practice to add a comment explaining why this specific Docker API version is being pinned. This provides context for future developers, especially when the CI's Docker daemon is upgraded.

# Pin Docker API version to be compatible with the Docker daemon on CI.
# The daemon's maximum supported API version is 1.43.
ENV DOCKER_API_VERSION=1.43

RUN <<EOF
#!/bin/bash

Expand Down