pinning docker api version #59047
pinning docker api version #59047
Conversation
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request pins the Docker API version to 1.43 to resolve a client-server version mismatch error in the CI environment. The change involves setting the DOCKER_API_VERSION environment variable in the base.test.Dockerfile, which is the correct approach. I have one suggestion to add a comment to improve the maintainability of this change.
| ENV RAY_INSTALL_JAVA=0 | ||
| ENV BUILDKITE_BAZEL_CACHE_URL=${BUILDKITE_BAZEL_CACHE_URL} | ||
|
|
||
| ENV DOCKER_API_VERSION=1.43 |
There was a problem hiding this comment.
To improve maintainability, it's good practice to add a comment explaining why this specific Docker API version is being pinned. This provides context for future developers, especially when the CI's Docker daemon is upgraded.
# Pin Docker API version to be compatible with the Docker daemon on CI.
# The daemon's maximum supported API version is 1.43.
ENV DOCKER_API_VERSION=1.43
Signed-off-by: elliot-barn <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| --cache-test-results --parallelism-per-worker 2 | ||
| --build-name oss-ci-base_test-py3.10 | ||
| --build-type skip | ||
| - docker version |
There was a problem hiding this comment.
Bug: Debug command accidentally committed to CI configuration
The docker version command appears to be debugging code left over from investigating the Docker API version issue. It's only added to the "reef-tests" job and not to other similar jobs in the file, and it doesn't contribute to the actual fix (which is the DOCKER_API_VERSION environment variable in the Dockerfile). This was likely used during development to verify Docker configuration and inadvertently included in the PR.
|
the docker version pin fix is this one: |
pinning docker api version due to docker client error: Error response from daemon: client version 1.52 is too new. Maximum supported API version is 1.43