[Core] Remove add_command_alias #58719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
jjyao
requested review from
aslonnie,
edoakes and
richardliaw
as code owners
aslonnie
approved these changes
Nov 18, 2025
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the add_command_alias function to address a deepcopy issue with newer versions of the click library. While this correctly removes several deprecated aliases, it also has the side effect of making some hidden commands (rsync_down, rsync_up, get_head_ip) visible in the CLI. My review provides suggestions to keep these commands hidden without using the problematic function, thus preserving the intended CLI interface.
edoakes
approved these changes
Nov 18, 2025
Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Nov 18, 2025
`add_command_alias` deepcopy the `Command` object but it's no longer deep-copyable: pallets/click#3065 (comment). We can remove it completely since it just creates some command aliases that have been deprecated for 5+ years. Closes ray-project#56747 --------- Signed-off-by: Jiajun Yao <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
`add_command_alias` deepcopy the `Command` object but it's no longer deep-copyable: pallets/click#3065 (comment). We can remove it completely since it just creates some command aliases that have been deprecated for 5+ years. Closes ray-project#56747 --------- Signed-off-by: Jiajun Yao <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
`add_command_alias` deepcopy the `Command` object but it's no longer deep-copyable: pallets/click#3065 (comment). We can remove it completely since it just creates some command aliases that have been deprecated for 5+ years. Closes ray-project#56747 --------- Signed-off-by: Jiajun Yao <[email protected]> Signed-off-by: YK <[email protected]>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
`add_command_alias` deepcopy the `Command` object but it's no longer deep-copyable: pallets/click#3065 (comment). We can remove it completely since it just creates some command aliases that have been deprecated for 5+ years. Closes ray-project#56747 --------- Signed-off-by: Jiajun Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add_command_aliasdeepcopy theCommandobject but it's no longer deep-copyable: pallets/click#3065 (comment). We can remove it completely since it just creates some command aliases that have been deprecated for 5+ years.Related issues
Closes #56747