Skip to content

[Core] Remove add_command_alias #58719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edoakes merged 4 commits into from
Nov 18, 2025
Merged

[Core] Remove add_command_alias #58719

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf822b2
Remove add_command_alias
jjyao Nov 18, 2025
1177a5d
up
jjyao Nov 18, 2025
f5fae81
up
jjyao Nov 18, 2025
a6b5000
up
jjyao Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions python/ray/scripts/scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2769,29 +2769,16 @@ def get_auth_token(generate):
# Print token to stdout (for piping) without newline
click.echo(token, nl=False)


def add_command_alias(command, name, hidden):
new_command = copy.deepcopy(command)
new_command.hidden = hidden
cli.add_command(new_command, name=name)


cli.add_command(dashboard)
cli.add_command(debug)
cli.add_command(start)
cli.add_command(stop)
cli.add_command(up)
add_command_alias(up, name="create_or_update", hidden=True)
cli.add_command(attach)
cli.add_command(exec)
add_command_alias(exec, name="exec_cmd", hidden=True)
add_command_alias(rsync_down, name="rsync_down", hidden=True)
add_command_alias(rsync_up, name="rsync_up", hidden=True)
cli.add_command(submit)
cli.add_command(down)
add_command_alias(down, name="teardown", hidden=True)
cli.add_command(kill_random_node)
add_command_alias(get_head_ip, name="get_head_ip", hidden=True)
cli.add_command(get_worker_ips)
cli.add_command(microbenchmark)
cli.add_command(stack)
Expand Down Expand Up @@ -2822,16 +2809,16 @@ def add_command_alias(command, name, hidden):

cli.add_command(ray_list, name="list")
cli.add_command(ray_get, name="get")
add_command_alias(summary_state_cli_group, name="summary", hidden=False)
add_command_alias(logs_state_cli_group, name="logs", hidden=False)
cli.add_command(summary_state_cli_group, name="summary")
cli.add_command(logs_state_cli_group, name="logs")
except ImportError as e:
logger.debug(f"Integrating ray state command line tool failed: {e}")


try:
from ray.dashboard.modules.job.cli import job_cli_group

add_command_alias(job_cli_group, name="job", hidden=False)
cli.add_command(job_cli_group, name="job")
except Exception as e:
logger.debug(f"Integrating ray jobs command line tool failed with {e}")

Expand Down
4 changes: 1 addition & 3 deletions python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
# You can obtain this list from the ray.egg-info/requires.txt

## setup.py install_requires
# Click 8.3.* does not work with copy.deepcopy on Python 3.10
# TODO(aslonnie): https://github.com/ray-project/ray/issues/56747
click>=7.0, !=8.3.*
click>=7.0
cupy-cuda12x; sys_platform != 'darwin'
filelock
jsonschema
Expand Down
4 changes: 1 addition & 3 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,9 +402,7 @@ def get_packages(self):
# new releases candidates.
if setup_spec.type == SetupType.RAY:
setup_spec.install_requires = [
# Click 8.3.* does not work with copy.deepcopy on Python 3.10
# TODO(aslonnie): https://github.com/ray-project/ray/issues/56747
"click>=7.0, !=8.3.*",
"click>=7.0",
"filelock",
"jsonschema",
"msgpack >= 1.0.0, < 2.0.0",
Expand Down