Skip to content

[ci] reef tests on py310 #58379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

[ci] reef tests on py310 #58379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .buildkite/cicd.rayci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ steps:
//ci/ray_ci/... //release/... //ci/pipeline/... ci
--only-tags=release_unit,ci_unit
--cache-test-results --parallelism-per-worker 2
--build-name oss-ci-base_test
--build-name oss-ci-base_test-py3.10
--build-type skip
instance_type: small
depends_on:
- oss-ci-base_test
- oss-ci-base_test-multipy
- forge
tags: tools
- label: ":coral: reef: raydepsets tests"
Expand All @@ -20,30 +20,30 @@ steps:
- bazel run //ci/ray_ci:test_in_docker --
//ci/raydepsets/... ci
--cache-test-results
--build-name oss-ci-base_test
--build-name oss-ci-base_test-py3.10
--build-type skip
instance_type: small
depends_on:
- oss-ci-base_test
- oss-ci-base_test-multipy
- forge
tags: tools
- label: ":coral: reef: privileged container tests"
commands:
- bazel run //ci/ray_ci:test_in_docker --
//ci/ray_ci:test_privileged ci
--cache-test-results
--build-name oss-ci-base_test
--build-name oss-ci-base_test-py3.10
--build-type cgroup
--privileged
instance_type: small
depends_on:
- oss-ci-base_test
- oss-ci-base_test-multipy
- forge
tags: tools
- label: ":coral: reef: iwyu tests"
commands:
- bazel test --config iwyu //bazel/tests/cpp:example_test
instance_type: small
depends_on: oss-ci-base_build
job_env: oss-ci-base_build
depends_on: oss-ci-base_build-multipy
job_env: oss-ci-base_build-py3.10
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The iwyu test is a C++ static analysis check, but it's being configured to run in a Python 3.10-specific environment. This creates a tight coupling between C++ tooling and a specific Python version, which could complicate future maintenance and upgrades. If the iwyu toolchain does not have a strict dependency on Python 3.10, it would be more robust to use a generic build environment. This would help ensure that C++ checks are not inadvertently affected by changes in Python environments.

tags: tools