[ci] reef tests on py310 #58379
[ci] reef tests on py310 #58379
Conversation
Signed-off-by: elliot-barn <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Buildkite CI configuration to run 'reef' tests on Python 3.10. The changes involve updating build names and dependencies to use Python 3.10-specific environments and multi-python build steps. The modifications are consistent across the affected jobs. I have one suggestion regarding the environment for the C++ iwyu test to improve long-term maintainability by decoupling it from a specific Python version.
| depends_on: oss-ci-base_build | ||
| job_env: oss-ci-base_build | ||
| depends_on: oss-ci-base_build-multipy | ||
| job_env: oss-ci-base_build-py3.10 |
There was a problem hiding this comment.
The iwyu test is a C++ static analysis check, but it's being configured to run in a Python 3.10-specific environment. This creates a tight coupling between C++ tooling and a specific Python version, which could complicate future maintenance and upgrades. If the iwyu toolchain does not have a strict dependency on Python 3.10, it would be more robust to use a generic build environment. This would help ensure that C++ checks are not inadvertently affected by changes in Python environments.
upgrading reef tests to run on 3.10 Signed-off-by: elliot-barn <[email protected]>
upgrading reef tests to run on 3.10 Signed-off-by: elliot-barn <[email protected]>
upgrading reef tests to run on 3.10 Signed-off-by: elliot-barn <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
upgrading reef tests to run on 3.10 Signed-off-by: elliot-barn <[email protected]>
upgrading reef tests to run on 3.10