Skip to content

[core] Enable cgroup unit tests in CI #51864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjyao merged 6 commits into from
Apr 1, 2025
Merged

[core] Enable cgroup unit tests in CI #51864

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c5983c2
enable unit test in CI
dentiny Mar 31, 2025
901ac0e
switch to tester argument
dentiny Apr 1, 2025
d7c1c86
fix except tags
dentiny Apr 1, 2025
5da4461
revert container test change
dentiny Apr 1, 2025
5904e6f
add another cgroup test suite
dentiny Apr 1, 2025
932bcb9
no need for parallel worker
dentiny Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions .buildkite/core.rayci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,34 +293,41 @@ steps:
- "3.13"

# cpp tests
- label: ":ray: core: cgroup tests"
tags: core_cpp
instance_type: medium
commands:
- bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core --only-tags=cgroup --build-type cgroup
--privileged --cache-test-results --parallelism-per-worker 2

- label: ":ray: core: cpp tests"
tags: core_cpp
instance_type: medium
commands:
- bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core --build-type clang
- bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core --except-tags=cgroup --build-type clang
--cache-test-results --parallelism-per-worker 2

- label: ":ray: core: cpp asan tests"
tags: core_cpp
instance_type: medium
commands:
- bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core --build-type asan-clang
--cache-test-results --parallelism-per-worker 2
- bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core --except-tags=cgroup
--build-type asan-clang --cache-test-results --parallelism-per-worker 2

- label: ":ray: core: cpp ubsan tests"
tags: core_cpp
instance_type: large
commands:
- bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core --build-type ubsan
--except-tags no_ubsan
- bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core
--build-type ubsan --except-tags no_ubsan,cgroup
--cache-test-results --parallelism-per-worker 2

- label: ":ray: core: cpp tsan tests"
tags: core_cpp
instance_type: medium
commands:
- bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core --build-type tsan-clang
--except-tags no_tsan
- bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core
--build-type tsan-clang --except-tags no_tsan,cgroup
Copy link
Collaborator

@aslonnie aslonnie Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so where is the cgroup test being run?

Copy link
Contributor Author

@dentiny dentiny Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to make sure I understand correctly, here I add cgroup tag to filter group, not apply group. So cgroup will not be executed for cpp TSAN test.

--cache-test-results --parallelism-per-worker 2

- label: ":ray: core: flaky cpp tests"
Expand Down
3 changes: 1 addition & 2 deletions src/ray/common/cgroup/test/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ ray_cc_test(
size = "small",
srcs = ["cgroup_v2_utils_privileged_test.cc"],
tags = [
# TODO(hjiang, ibrahim, lonnie): Setup CI for cgroup testing environment.
"manual",
"cgroup",
"exclusive",
"team:core",
],
Expand Down