[core] Enable cgroup unit tests in CI #51864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/enable-cgroup-unit-test
branch
from
e81c9e2 to
c5983c2
Compare
Signed-off-by: dentiny <[email protected]>
dentiny
force-pushed
the
hjiang/enable-cgroup-unit-test
branch
from
54f71c0 to
901ac0e
Compare
Signed-off-by: dentiny <[email protected]>
aslonnie
reviewed
Apr 1, 2025
| - bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core --build-type tsan-clang | ||
| --except-tags no_tsan | ||
| - bazel run //ci/ray_ci:test_in_docker -- //:all //src/... core | ||
| --build-type tsan-clang --except-tags no_tsan,cgroup |
Collaborator
There was a problem hiding this comment.
so where is the cgroup test being run?
Contributor
Author
There was a problem hiding this comment.
I want to make sure I understand correctly, here I add cgroup tag to filter group, not apply group. So cgroup will not be executed for cpp TSAN test.
dentiny
changed the title
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
dentiny
changed the title
aslonnie
approved these changes
Apr 1, 2025
Signed-off-by: dentiny <[email protected]>
Contributor
Author
Collaborator
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup for #51454, which does: