Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/N] bazel lint C++ code #50869

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Feb 25, 2025

A split PR for #50846, as suggested by @aslonnie

@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Feb 25, 2025
Signed-off-by: dentiny <[email protected]>
@dentiny dentiny force-pushed the hjiang/bazel-lint-part-1 branch from 7a6954f to 3de65ed Compare February 25, 2025 00:29
@edoakes edoakes enabled auto-merge (squash) February 25, 2025 00:39
rev: 8.0.1
hooks:
- id: buildifier
files: ^src/ray(?:/[^/]+)*/BUILD$
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just filter based on prefix, the buildifier plugin normally won't touch other files.

@aslonnie
Copy link
Collaborator

and not sure why the doc build is failing..

@edoakes edoakes merged commit 27e356b into ray-project:master Feb 25, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants