Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce baze linter for precommit and cleanup all BUILD file #50846

Closed
wants to merge 1 commit into from

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Feb 23, 2025

As titled, all changes are made and auto-fixed by linter.

@dentiny dentiny requested a review from aslonnie February 23, 2025 22:58
@dentiny dentiny requested a review from jjyao February 23, 2025 22:59
@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Feb 23, 2025
@dentiny dentiny force-pushed the hjiang/precommit-bazel branch from 797e77d to 9f3a95d Compare February 23, 2025 23:01
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @aslonnie any comments?

@dentiny dentiny force-pushed the hjiang/precommit-bazel branch from ba776ee to 9f3a95d Compare February 24, 2025 21:25
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe split the changes in smaller parts so that it is easier to review / detect issues / make progress?

@dentiny
Copy link
Contributor Author

dentiny commented Feb 25, 2025

maybe split the changes in smaller parts so that it is easier to review / detect issues / make progress?

Discussed offline, I will split it into smaller PRs.

@dentiny dentiny closed this Feb 25, 2025
edoakes pushed a commit that referenced this pull request Feb 25, 2025
A split PR for #50846, as
suggested by @aslonnie

Signed-off-by: dentiny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants