Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llm] change llm base from ml base to test base #50355

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Feb 8, 2025

it is a smaller image

@aslonnie aslonnie requested a review from a team as a code owner February 8, 2025 16:39
it is a smaller image

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie force-pushed the lonnie-250208-llmbase branch from b9d7704 to 00331e8 Compare February 8, 2025 17:22
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Feb 8, 2025
@aslonnie aslonnie changed the title [llm] change test base from ml base to test base [llm] change llm base from ml base to test base Feb 8, 2025
@aslonnie aslonnie requested a review from comaniac February 8, 2025 21:47
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also help review the CI config changes in #50270?

@aslonnie aslonnie merged commit 491f5fa into master Feb 9, 2025
6 checks passed
@aslonnie aslonnie deleted the lonnie-250208-llmbase branch February 9, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants