-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LLM Batch][4/N] vLLM engine stage #50270
Conversation
ec4e3ce
to
4c2161d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kouroshHakha CI green. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small comments around test org + some nits:
@@ -1,8 +1,15 @@ | |||
load("//bazel:python.bzl", "py_test_module_list") | |||
|
|||
py_test_module_list( | |||
files = glob(["test_*.py"]), | |||
files = glob(["test_*.py"], exclude=["test_vllm_engine_stage.py"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so what I am saying is we need to a bit of file reorg to make the BUILD files cleaner. What do you think about this suggestion:
Make the folder structure as following:
python/ray/llm/tests
-- batch
BUILD
----- gpu
-------- stages
----------- vllm_engine_stage_gpu.py
----- cpu
------- stages
...
in the BUILD do sth like
py_test_module_list(
files = glob(["cpu/*/test_*.py"]),
size = "small",
tags = ["exclusive", "team:llm"],
deps = ["//:ray_lib"],
)
py_test_module_list(
files = glob(["gpu/*/test_*.py"]),
size = "large",
tags = ["exclusive", "gpu", "team:llm"],
deps = ["//:ray_lib"],
)
b45d962
to
14450b9
Compare
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
498eb7d
to
37beaf0
Compare
Signed-off-by: Cody Yu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's goooooo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve this to get unblocked :)
Let's make sure we have a docs page and good documentation once this is ready :)
Why are these changes needed?
This PR introduces vLLM engine stage with the following features:
This PR doesn't support:
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.