Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM Batch][4/N] vLLM engine stage #50270

Merged
merged 17 commits into from
Feb 11, 2025

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Feb 5, 2025

Why are these changes needed?

This PR introduces vLLM engine stage with the following features:

  • Decoding models.
  • Embedding models.
  • vLLM v0 and vLLM v1.
  • TP and PP.

This PR doesn't support:

  • Vision models.
  • End to end vLLM processor.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@comaniac comaniac requested a review from a team as a code owner February 7, 2025 00:12
@comaniac comaniac added go add ONLY when ready to merge, run all tests and removed go add ONLY when ready to merge, run all tests labels Feb 7, 2025
@comaniac
Copy link
Collaborator Author

comaniac commented Feb 7, 2025

@kouroshHakha CI green. PTAL

Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small comments around test org + some nits:

@@ -1,8 +1,15 @@
load("//bazel:python.bzl", "py_test_module_list")

py_test_module_list(
files = glob(["test_*.py"]),
files = glob(["test_*.py"], exclude=["test_vllm_engine_stage.py"]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what I am saying is we need to a bit of file reorg to make the BUILD files cleaner. What do you think about this suggestion:

Make the folder structure as following:

python/ray/llm/tests
-- batch 
BUILD
----- gpu
-------- stages
----------- vllm_engine_stage_gpu.py
----- cpu
------- stages
...

in the BUILD do sth like

py_test_module_list(
  files = glob(["cpu/*/test_*.py"]),
  size = "small",
  tags = ["exclusive", "team:llm"],
  deps = ["//:ray_lib"],
)

py_test_module_list(
  files = glob(["gpu/*/test_*.py"]),
  size = "large",
  tags = ["exclusive", "gpu", "team:llm"],
  deps = ["//:ray_lib"],
)

Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooooo

@kouroshHakha kouroshHakha enabled auto-merge (squash) February 11, 2025 22:28
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this to get unblocked :)

Let's make sure we have a docs page and good documentation once this is ready :)

@kouroshHakha kouroshHakha merged commit 5c53b9e into ray-project:master Feb 11, 2025
6 checks passed
@comaniac comaniac deleted the llm-batch-vllm branch February 11, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants