Skip to content

[Data] Fix missing lines in BundleQueue docstring #48553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bveeramani merged 2 commits into from
Nov 5, 2024
Merged

[Data] Fix missing lines in BundleQueue docstring #48553

bveeramani merged 2 commits into from
Nov 5, 2024

Conversation

@bveeramani
Copy link
Member

@bveeramani bveeramani commented Nov 5, 2024

Why are these changes needed?

Follow-up to #48503.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Fix typo
d2b0fe0 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Fix another line
ffee6ce 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani enabled auto-merge (squash) November 5, 2024 00:12
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 5, 2024
@bveeramani bveeramani merged commit 27faad3 into master Nov 5, 2024
@bveeramani bveeramani deleted the docstring-typo branch November 5, 2024 01:03
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@bveeramani @JP-sDEV
[Data] Fix missing lines in BundleQueue docstring (ray-project#48553)
1fc6446 
Follow-up to ray-project#48503.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@bveeramani @mohitjain2504
[Data] Fix missing lines in BundleQueue docstring (ray-project#48553)
5d4ed07 
Follow-up to ray-project#48503.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@omatthew98 omatthew98 omatthew98 approved these changes

@scottjlee scottjlee Awaiting requested review from scottjlee

@raulchen raulchen Awaiting requested review from raulchen

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

@alexeykudinkin alexeykudinkin Awaiting requested review from alexeykudinkin

Assignees

@omatthew98 omatthew98

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bveeramani @omatthew98