Skip to content

[Data] Add BundleQueue abstraction #48503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bveeramani merged 3 commits into from
Nov 4, 2024
Merged

[Data] Add BundleQueue abstraction #48503

bveeramani merged 3 commits into from
Nov 4, 2024

Conversation

@bveeramani
Copy link
Member

@bveeramani bveeramani commented Nov 1, 2024

Why are these changes needed?

Two reasons for adding this abstraction:

  1. It allows us to customize how we pop bundles from OpState and internal queues. Currently, we pop the first-in bundle, but you might want a less naive strategy.
  2. It allows us to keep track of bundles in OpRuntimeMetrics so that we can refresh stale bundle sizes.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
922b074 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Fix minor error
47982e9 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Fix test
0e2023b 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani enabled auto-merge (squash) November 4, 2024 20:54
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 4, 2024
@bveeramani bveeramani merged commit fab26e1 into master Nov 4, 2024
7 checks passed
@bveeramani bveeramani deleted the bundle-queue branch November 4, 2024 22:52
frances720 added a commit to Promptless/ray-test that referenced this pull request Nov 5, 2024
@frances720
[Data] Add BundleQueue abstraction (ray-project#48503)
0c51505
@bveeramani bveeramani mentioned this pull request Nov 5, 2024
Merged
8 tasks
bveeramani added a commit that referenced this pull request Nov 5, 2024
@bveeramani
[Data] Fix missing lines in BundleQueue docstring (#48553)
27faad3 
Follow-up to #48503.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani added a commit that referenced this pull request Nov 6, 2024
@bveeramani
Revert "[Data] Add BundleQueue abstraction (#48503)"
98c85b9 
This reverts commit fab26e1.

Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani added a commit that referenced this pull request Nov 7, 2024
@bveeramani
Revert "[Data] Add BundleQueue abstraction (#48503)" (#48612)
4a9c424 
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani added a commit that referenced this pull request Nov 11, 2024
@bveeramani
Revert "Revert "[Data] Add BundleQueue abstraction (#48503)" (#48612)"
3903f19 
This reverts commit 4a9c424.

Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani added a commit that referenced this pull request Nov 13, 2024
@bveeramani
Revert "Revert "[Data] Add BundleQueue abstraction (#48503)" (#48612)…
4b4cdcd 
…" (#48686)

This reverts commit 4a9c424.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@bveeramani @JP-sDEV
[Data] Add BundleQueue abstraction (ray-project#48503)
4cd8b7c 
Two reasons for adding this abstraction:

1. It allows us to customize how we pop bundles from OpState and internal queues. Currently, we pop the first-in bundle, but you might want a less naive strategy.
2. It allows us to keep track of bundles in OpRuntimeMetrics so that we can refresh stale bundle sizes.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@bveeramani @JP-sDEV
[Data] Fix missing lines in BundleQueue docstring (ray-project#48553)
1fc6446 
Follow-up to ray-project#48503.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@bveeramani @JP-sDEV
Revert "[Data] Add BundleQueue abstraction (ray-project#48503)" (ra…
af2a4f1 
…y-project#48612)

Signed-off-by: Balaji Veeramani <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@bveeramani @JP-sDEV
Revert "Revert "[Data] Add BundleQueue abstraction (ray-project#48503…
949a9db 
…)" (ray-project#48612)" (ray-project#48686)

This reverts commit 4a9c424.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@bveeramani @mohitjain2504
[Data] Add BundleQueue abstraction (ray-project#48503)
65b223a 
Two reasons for adding this abstraction:

1. It allows us to customize how we pop bundles from OpState and internal queues. Currently, we pop the first-in bundle, but you might want a less naive strategy.
2. It allows us to keep track of bundles in OpRuntimeMetrics so that we can refresh stale bundle sizes.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@bveeramani @mohitjain2504
[Data] Fix missing lines in BundleQueue docstring (ray-project#48553)
5d4ed07 
Follow-up to ray-project#48503.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@bveeramani @mohitjain2504
Revert "[Data] Add BundleQueue abstraction (ray-project#48503)" (ra…
d5e2034 
…y-project#48612)

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@bveeramani @mohitjain2504
Revert "Revert "[Data] Add BundleQueue abstraction (ray-project#48503…
01e54cf 
…)" (ray-project#48612)" (ray-project#48686)

This reverts commit 4a9c424.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeykudinkin alexeykudinkin alexeykudinkin approved these changes

@scottjlee scottjlee Awaiting requested review from scottjlee

@raulchen raulchen Awaiting requested review from raulchen

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

@omatthew98 omatthew98 Awaiting requested review from omatthew98

Assignees

@alexeykudinkin alexeykudinkin

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bveeramani @alexeykudinkin