Skip to content

[data][docs] fix broken links#27818

Merged
richardliaw merged 3 commits intoray-project:masterfrom
matthewdeng:fix-data-links
Aug 12, 2022
Merged

[data][docs] fix broken links#27818
richardliaw merged 3 commits intoray-project:masterfrom
matthewdeng:fix-data-links

Conversation

@matthewdeng
Copy link
Contributor

Signed-off-by: Matthew Deng matt@anyscale.com

Why are these changes needed?

Follow-up to #27592.

Fixes the broken links (which didn't surface until master docs updated):

(ray-core/package-ref: line   18) broken    https://docs.ray.io/en/master/data/package-ref.html#ray.data.Dataset.map_batches - 404 Client Error: Not Found for url: https://docs.ray.io/en/master/data/package-ref.html
(ray-air/examples/torch_incremental_learning: line 110015) broken    https://docs.ray.io/en/master/data/package-ref.html?highlight=SimpleTorchDatasource#ray.data.datasource.SimpleTorchDatasource - 404 Client Error: Not Found for url: https://docs.ray.io/en/master/data/package-ref.html?highlight=SimpleTorchDatasource

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <matt@anyscale.com>
+
Signed-off-by: Matthew Deng <matt@anyscale.com>
@matthewdeng matthewdeng requested a review from a team as a code owner August 12, 2022 08:41
@matthewdeng matthewdeng added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Aug 12, 2022
@matthewdeng
Copy link
Contributor Author

Test failure is unrelated and transient(?)

(serve/performance: line   22) broken    https://github.com/ray-project/ray/blob/master/release/benchmarks/README.md - 500 Server Error: Internal Server Error for url: https://github.com/ray-project/ray/blob/master/release/benchmarks/README.md

https://github.com/ray-project/ray/blob/master/release/benchmarks/README.md works fine

" <!-- and also means that any transformations done to the images can be done in a zero-copy fashion. -->\n",
"\n",
"For this example, since we are just working with MNIST dataset, which is small, we use the [`SimpleTorchDataSource`](https://docs.ray.io/en/master/data/package-ref.html?highlight=SimpleTorchDatasource#ray.data.datasource.SimpleTorchDatasource) which just loads the full MNIST dataset into memory.\n",
"For this example, since we are just working with MNIST dataset, which is small, we use the [`SimpleTorchDataSource`](https://docs.ray.io/en/master/data/api/input_output.html?highlight=SimpleTorchDatasource#ray.data.datasource.SimpleTorchDatasource) which just loads the full MNIST dataset into memory.\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update this to be a proper internal ref

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯 updated!

Signed-off-by: Matthew Deng <matt@anyscale.com>
@richardliaw richardliaw merged commit 58495fe into ray-project:master Aug 12, 2022
matthewdeng added a commit to matthewdeng/ray that referenced this pull request Aug 12, 2022
matthewdeng added a commit that referenced this pull request Aug 13, 2022
* [data] update datasets API structure (#27592)
* [data][docs] fix broken links (#27818)
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-ok The tagger certifies test failures are unrelated and assumes personal liability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants