Fix build failure while using make -j1. Issue 2257#2279
Merged
pcmoritz merged 2 commits intoray-project:masterfrom Jun 21, 2018
Merged
Fix build failure while using make -j1. Issue 2257#2279pcmoritz merged 2 commits intoray-project:masterfrom
pcmoritz merged 2 commits intoray-project:masterfrom
Conversation
|
Test PASSed. |
Contributor
|
@guoyuhong This seems to make the java tests run (even after restarting it), can you have a look at that? |
Contributor
Author
|
Sure, I will take a look. |
|
Test PASSed. |
Contributor
Author
|
@pcmoritz I have fixed this test failure. I referred a dependency which is only generated in Python, which caused the failure. |
royf
added a commit
to royf/ray
that referenced
this pull request
Jun 22, 2018
* 'master' of https://github.com/ray-project/ray: (157 commits) Fix build failure while using make -j1. Issue 2257 (ray-project#2279) Cast locator with index type (ray-project#2274) fixing zero length partitions (ray-project#2237) Make actor handles work in Python mode. (ray-project#2283) [xray] Add error table and push error messages to driver through node manager. (ray-project#2256) addressing comments (ray-project#2210) Re-enable some actor tests. (ray-project#2276) Experimental: enable automatic GCS flushing with configurable policy. (ray-project#2266) [xray] Sets good object manager defaults. (ray-project#2255) [tune] Update Trainable doc to expose interface (ray-project#2272) [rllib] Add a simple REST policy server and client example (ray-project#2232) [asv] Pushing to s3 (ray-project#2246) [rllib] Remove need to pass around registry (ray-project#2250) Support multiple availability zones in AWS (fix ray-project#2177) (ray-project#2254) [rllib] Add squash_to_range model option (ray-project#2239) Mitigate randomly building failure: adding gen_local_scheduler_fbs to raylet lib. (ray-project#2271) [rllib] Refactor Multi-GPU for PPO (ray-project#1646) [rllib] Envs for vectorized execution, async execution, and policy serving (ray-project#2170) [Dataframe] Change pandas and ray.dataframe imports (ray-project#1942) [Java] Replace binary rewrite with Remote Lambda Cache (SerdeLambda) (ray-project#2245) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I compared the build log provided by Issue 2257 with mine. The setting is
make -j1. In most cases, we use multi-thread, so some missing dependencies will not be a problem since other threads may finish building the dependency in time.This change fix all the missing dependencies and now we can build ray with
make -j1.Related issue number
2257
2185