Skip to content

[xray] Add error table and push error messages to driver through node manager.#2256

Merged
pcmoritz merged 12 commits intoray-project:masterfrom
robertnishihara:xraypusherrorstodriver
Jun 21, 2018
Merged

[xray] Add error table and push error messages to driver through node manager.#2256
pcmoritz merged 12 commits intoray-project:masterfrom
robertnishihara:xraypusherrorstodriver

Conversation

@robertnishihara
Copy link
Collaborator

@robertnishihara robertnishihara commented Jun 15, 2018

No description provided.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 15, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6065/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 15, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6070/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6117/
Test FAILed.

@robertnishihara robertnishihara changed the title [WIP] [xray] Add error table and push error messages to driver through node manager. [xray] Add error table and push error messages to driver through node manager. Jun 19, 2018
@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6126/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6127/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6129/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6128/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6135/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6136/
Test FAILed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 19, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6139/
Test FAILed.

@robertnishihara
Copy link
Collaborator Author

robertnishihara commented Jun 19, 2018

jenkins retest this please

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6140/
Test PASSed.

pcmoritz
pcmoritz reviewed Jun 20, 2018
View reviewed changes
src/ray/raylet/node_manager.cc Outdated
Copy link
Contributor

@pcmoritz pcmoritz Jun 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this one into src/ray/util/util.h (without the _duplicate) then so we can start sorting the other ones out then. Otherwise, the situation is only going to get worse.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6165/
Test PASSed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jun 20, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6166/
Test PASSed.

@pcmoritz pcmoritz merged commit ff22172 into ray-project:master Jun 21, 2018
@pcmoritz pcmoritz deleted the xraypusherrorstodriver branch June 21, 2018 04:29
royf added a commit to royf/ray that referenced this pull request Jun 22, 2018
@royf
Merge branch 'master' of https://github.com/ray-project/ray
d1a3e44 
* 'master' of https://github.com/ray-project/ray: (157 commits)
  Fix build failure while using make -j1. Issue 2257 (ray-project#2279)
  Cast locator with index type (ray-project#2274)
  fixing zero length partitions (ray-project#2237)
  Make actor handles work in Python mode. (ray-project#2283)
  [xray] Add error table and push error messages to driver through node manager. (ray-project#2256)
  addressing comments (ray-project#2210)
  Re-enable some actor tests. (ray-project#2276)
  Experimental: enable automatic GCS flushing with configurable policy. (ray-project#2266)
  [xray] Sets good object manager defaults. (ray-project#2255)
  [tune] Update Trainable doc to expose interface (ray-project#2272)
  [rllib] Add a simple REST policy server and client example (ray-project#2232)
  [asv] Pushing to s3 (ray-project#2246)
  [rllib] Remove need to pass around registry (ray-project#2250)
  Support multiple availability zones in AWS (fix ray-project#2177) (ray-project#2254)
  [rllib] Add squash_to_range model option (ray-project#2239)
  Mitigate randomly building failure: adding gen_local_scheduler_fbs to raylet lib. (ray-project#2271)
  [rllib] Refactor Multi-GPU for PPO (ray-project#1646)
  [rllib] Envs for vectorized execution, async execution, and policy serving (ray-project#2170)
  [Dataframe] Change pandas and ray.dataframe imports (ray-project#1942)
  [Java] Replace binary rewrite with Remote Lambda Cache (SerdeLambda) (ray-project#2245)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcmoritz pcmoritz pcmoritz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robertnishihara @AmplabJenkins @pcmoritz