Do not fetch from dead Plasma Manager#2116
Merged
robertnishihara merged 1 commit intoray-project:masterfrom May 23, 2018
Merged
Do not fetch from dead Plasma Manager#2116robertnishihara merged 1 commit intoray-project:masterfrom
robertnishihara merged 1 commit intoray-project:masterfrom
Conversation
|
Test PASSed. |
robertnishihara
approved these changes
May 23, 2018
Collaborator
robertnishihara
left a comment
robertnishihara
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me. The test failure should be unrelated.
alok
added a commit
to alok/ray
that referenced
this pull request
May 25, 2018
* master: Prototype named actors. (ray-project#2129) Update arrow to latest master (ray-project#2100) [DataFrame] Speed up dtypes (ray-project#2118) do not fetch from dead Plasma Manager (ray-project#2116) [DataFrame] Refactor GroupBy Methods and Implement Reindex (ray-project#2101) Initial Support for Airspeed Velocity (ray-project#2113) Use automatic memory management in Redis modules. (ray-project#1797) [DataFrame] Test bugfixes (ray-project#2111) [DataFrame] Update initializations of IndexMetadata which use outdated APIs (ray-project#2103)
alok
added a commit
to alok/ray
that referenced
this pull request
May 30, 2018
* fix-a3c-torch: Prototype named actors. (ray-project#2129) Update arrow to latest master (ray-project#2100) [DataFrame] Speed up dtypes (ray-project#2118) do not fetch from dead Plasma Manager (ray-project#2116)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the execution of cleanup_object_table() in monitor.py, objects in the dead Plasma manager may be fetched by others. This manager has been marked as "deleted" but the object location tables may have not been cleaned up yet.
This logic would cause:
After looking up DB client table, filter the result to drop dead Plasma managers.