Skip to content

Initial Support for Airspeed Velocity - #2113

Merged
pcmoritz merged 16 commits into
ray-project:masterfrom
richardliaw:asv
May 22, 2018
Merged

Initial Support for Airspeed Velocity#2113
pcmoritz merged 16 commits into
ray-project:masterfrom
richardliaw:asv

Conversation

@richardliaw

@richardliaw richardliaw commented May 21, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is to address a variety of regression testing TODOs, and also should partially address #2112.

@AmplabJenkins

AmplabJenkins commented May 21, 2018

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5535/
Test FAILed.

@richardliaw richardliaw changed the title WIP: Support Airspeed Velocity Initial Support for Airspeed Velocity May 21, 2018
pcmoritz
pcmoritz reviewed May 21, 2018
View reviewed changes

@pcmoritz pcmoritz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple Benchmarks.md file that tells people how to run the benchmarks?

@richardliaw richardliaw mentioned this pull request May 21, 2018
Closed
7 tasks
@AmplabJenkins

AmplabJenkins commented May 21, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5544/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 21, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5545/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 21, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5546/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 22, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5548/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 22, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5549/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 22, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5568/
Test PASSed.

@richardliaw
richardliaw requested review from pcmoritz and removed request for pcmoritz May 22, 2018 18:01
@pcmoritz

pcmoritz commented May 22, 2018

Copy link
Copy Markdown
Contributor

Thanks, there was another linting error which I fixed now, I'll merge it when the tests pass (https://travis-ci.com/robertnishihara/ray-private-travis/builds/74152646)

robertnishihara
robertnishihara reviewed May 22, 2018
View reviewed changes
Comment thread python/benchmarks/benchmarks.py
@@ -0,0 +1,26 @@
from __future__ import print_function

@robertnishihara robertnishihara May 22, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be

from __future__ import absolute_import
from __future__ import division
from __future__ import print_function

@robertnishihara robertnishihara May 22, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is autogenerated code.

robertnishihara
robertnishihara reviewed May 22, 2018
View reviewed changes
Comment thread python/README-benchmarks.md Outdated
@@ -0,0 +1,6 @@
# Running the benchmarks

@robertnishihara robertnishihara May 22, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we should use rst, not markdown

@AmplabJenkins

AmplabJenkins commented May 22, 2018

Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5574/
Test FAILed.

@pcmoritz

pcmoritz commented May 22, 2018

Copy link
Copy Markdown
Contributor

Jenkins retest this please

@AmplabJenkins

AmplabJenkins commented May 22, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5575/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 22, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5576/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 22, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5577/
Test PASSed.

@AmplabJenkins

AmplabJenkins commented May 22, 2018

Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/5578/
Test PASSed.

@pcmoritz
pcmoritz merged commit 01f6968 into ray-project:master May 22, 2018
@pcmoritz
pcmoritz deleted the asv branch May 22, 2018 23:20
alok added a commit to alok/ray that referenced this pull request May 24, 2018
@alok
Merge branch 'master' into trpo
9246b65 
* master:
  [DataFrame] Refactor GroupBy Methods and Implement Reindex (ray-project#2101)
  Initial Support for Airspeed Velocity (ray-project#2113)
  Use automatic memory management in Redis modules. (ray-project#1797)
  [DataFrame] Test bugfixes (ray-project#2111)
  [DataFrame] Update initializations of IndexMetadata which use outdated APIs (ray-project#2103)
alok added a commit to alok/ray that referenced this pull request May 25, 2018
@alok
Merge branch 'master' into fix-a3c-torch
e865a09 
* master:
  Prototype named actors. (ray-project#2129)
  Update arrow to latest master (ray-project#2100)
  [DataFrame] Speed up dtypes (ray-project#2118)
  do not fetch from dead Plasma Manager (ray-project#2116)
  [DataFrame] Refactor GroupBy Methods and Implement Reindex (ray-project#2101)
  Initial Support for Airspeed Velocity (ray-project#2113)
  Use automatic memory management in Redis modules. (ray-project#1797)
  [DataFrame] Test bugfixes (ray-project#2111)
  [DataFrame] Update initializations of IndexMetadata which use outdated APIs (ray-project#2103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertnishihara robertnishihara robertnishihara left review comments
@pcmoritz pcmoritz pcmoritz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardliaw @AmplabJenkins @pcmoritz @robertnishihara