Skip to content

Conversation

@ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Sep 21, 2020

#10659 removed --redis-port and several other arguments from ray start. This PR removes mentions across the codebase.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Is this comprehensive btw?

@ijrsvt
Copy link
Contributor Author

ijrsvt commented Sep 21, 2020

@wuisawesome I basically just searched for --redis-port.

@wuisawesome
Copy link
Contributor

Gotcha, so this is step 1 of #10697

@richardliaw richardliaw merged commit 4c3f090 into ray-project:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants