-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[1.0] Remove args from ray start #10659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ericl
approved these changes
Sep 9, 2020
rkooo567
reviewed
Sep 9, 2020
Contributor
Contributor
|
@wuisawesome please be more careful with the tests-ok tag, I did a double check and there were some failing tests! |
raulchen
reviewed
Sep 15, 2020
Contributor
|
Tests are failing: https://travis-ci.com/github/ray-project/ray/jobs/385303763 |
Contributor
|
LINT, etc still failing. Please do not add tests ok until you have carefully checked the tests, thanks. |
kfstorm
reviewed
Sep 17, 2020
barakmich
pushed a commit
that referenced
this pull request
Sep 21, 2020
Resolved Conflicts:
java/test.sh
python/ray/tests/test_multi_node.py
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P0
Issues that should be fixed in short order
release-blocker
P0 Issue that blocks the release
tests-ok
The tagger certifies test failures are unrelated and assumes personal liability.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.