Skip to content

Conversation

@wuisawesome
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@wuisawesome wuisawesome added release-blocker P0 Issue that blocks the release P0 Issues that should be fixed in short order labels Sep 8, 2020
@wuisawesome wuisawesome added this to the Ray 1.0 Bug Hotlist milestone Sep 8, 2020
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 9, 2020
@wuisawesome wuisawesome added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Sep 12, 2020
@ericl
Copy link
Contributor

ericl commented Sep 14, 2020

@ericl ericl added @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. and removed tests-ok The tagger certifies test failures are unrelated and assumes personal liability. labels Sep 14, 2020
@ericl
Copy link
Contributor

ericl commented Sep 14, 2020

@wuisawesome please be more careful with the tests-ok tag, I did a double check and there were some failing tests!

@ericl ericl changed the title [WIP] Remove args from ray start [1.0] Remove args from ray start Sep 14, 2020
@wuisawesome wuisawesome added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Sep 16, 2020
@richardliaw
Copy link
Contributor

Tests are failing: https://travis-ci.com/github/ray-project/ray/jobs/385303763

=================================== FAILURES ===================================
_________________________ test_calling_start_ray_head __________________________
call_ray_stop_only = None
    def test_calling_start_ray_head(call_ray_stop_only):
        # Test that we can call ray start with various command line
        # parameters. TODO(rkn): This test only tests the --head code path. We
        # should also test the non-head node code path.
    
        # Test starting Ray with no arguments.
        check_call_ray(["start", "--head"])
        check_call_ray(["stop"])
    
        # Test starting Ray with a redis port specified.
        check_call_ray(["start", "--head"])
        check_call_ray(["stop"])
    
        # Test starting Ray with a node IP address specified.
        check_call_ray(["start", "--head", "--node-ip-address", "127.0.0.1"])
        check_call_ray(["stop"])
    
        # Test starting Ray with a system config parameter set.
        check_call_ray([
            "start", "--head", "--system-config",
            "{\"metrics_report_interval_ms\":100}"
        ])
        check_call_ray(["stop"])
    
        # Test starting Ray with the object manager and node manager ports
        # specified.
        check_call_ray([
            "start", "--head", "--object-manager-port", "12345",
            "--node-manager-port", "54321"
        ])
        check_call_ray(["stop"])
    
        # Test starting Ray with the worker port range specified.
        check_call_ray([
            "start", "--head", "--min-worker-port", "50000", "--max-worker-port",
            "51000"
        ])
        check_call_ray(["stop"])
    
        # Test starting Ray with the number of CPUs specified.
        check_call_ray(["start", "--head", "--num-cpus", "2"])
        check_call_ray(["stop"])
    
        # Test starting Ray with the number of GPUs specified.
        check_call_ray(["start", "--head", "--num-gpus", "100"])
        check_call_ray(["stop"])
    
        # Test starting Ray with the max redis clients specified.
>       check_call_ray(["start", "--head", "--redis-max-clients", "100"])
/Users/travis/build/ray-project/ray/python/ray/tests/test_multi_node.py:419: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
args = ['start', '--head', '--redis-max-clients', '100'], capture_stdout = False
capture_stderr = False
    def check_call_ray(args, capture_stdout=False, capture_stderr=False):
        # We use this function instead of calling the "ray" command to work around
        # some deadlocks that occur when piping ray's output on Windows
        argv = ["ray"] + args
        if sys.platform == "win32":
            result = check_call_module(
                ray_main,
                argv,
                capture_stdout=capture_stdout,
                capture_stderr=capture_stderr)
        else:
            stdout_redir = None
            stderr_redir = None
            if capture_stdout:
                stdout_redir = subprocess.PIPE
            if capture_stderr and capture_stdout:
                stderr_redir = subprocess.STDOUT
            elif capture_stderr:
                stderr_redir = subprocess.PIPE
            proc = subprocess.Popen(argv, stdout=stdout_redir, stderr=stderr_redir)
            (stdout, stderr) = proc.communicate()
            if proc.returncode:
                raise subprocess.CalledProcessError(proc.returncode, argv, stdout,
>                                                   stderr)
E               subprocess.CalledProcessError: Command '['ray', 'start', '--head', '--redis-max-clients', '100']' returned non-zero exit status 2.

@richardliaw richardliaw removed the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 16, 2020
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 16, 2020
@ericl
Copy link
Contributor

ericl commented Sep 16, 2020

LINT, etc still failing. Please do not add tests ok until you have carefully checked the tests, thanks.

@wuisawesome wuisawesome added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Sep 18, 2020
@ericl ericl merged commit 9a07c7b into ray-project:master Sep 18, 2020
barakmich pushed a commit that referenced this pull request Sep 21, 2020
Resolved Conflicts:
        java/test.sh
        python/ray/tests/test_multi_node.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P0 Issues that should be fixed in short order release-blocker P0 Issue that blocks the release tests-ok The tagger certifies test failures are unrelated and assumes personal liability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants