-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[tune] Tune experiment analysis improvements #10645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
richardliaw
merged 21 commits into
ray-project:master
from
krfricke:tune-experiment-analysis
Sep 9, 2020
Merged
[tune] Tune experiment analysis improvements #10645
richardliaw
merged 21 commits into
ray-project:master
from
krfricke:tune-experiment-analysis
Sep 9, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # python/ray/tune/suggest/bohb.py # python/ray/tune/suggest/dragonfly.py # python/ray/tune/suggest/nevergrad.py # python/ray/tune/suggest/skopt.py # python/ray/tune/suggest/zoopt.py
krfricke
commented
Sep 8, 2020
richardliaw
reviewed
Sep 8, 2020
| return best_trial | ||
|
|
||
| def get_best_config(self, metric=None, mode=None, scope="all"): | ||
| def get_best_config(self, metric=None, mode=None, scope="last"): |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - need to explicitly say this on the release notes
richardliaw
reviewed
Sep 8, 2020
richardliaw
reviewed
Sep 8, 2020
Contributor
|
A couple tests failing - https://travis-ci.com/github/ray-project/ray/jobs/382378743 |
Contributor
Author
|
I'll fix these once the metric/mode got merged |
Contributor
Author
|
Actually updated them now. |
richardliaw
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Depends on successful merge of #10627.
This PR adds useful utility functions to the ExperimentAnalysis object. Most functions were available before, but these wrapper properties allow easy access without specifying any parameters as long as
modeandmetrichave been passed totune.run().It also introduces fetching pandas dataframes for the last trial results, a feature often found in other libraries.
The default lookup scope has been changed from
alltolast, as most users are interested comparing the final results, and not intermediate results.Related issue number
#10488
Checks
scripts/format.shto lint the changes in this PR.