Skip to content

Conversation

@krfricke
Copy link
Contributor

@krfricke krfricke commented Sep 8, 2020

Why are these changes needed?

Depends on successful merge of #10627.

This PR adds useful utility functions to the ExperimentAnalysis object. Most functions were available before, but these wrapper properties allow easy access without specifying any parameters as long as mode and metric have been passed to tune.run().

It also introduces fetching pandas dataframes for the last trial results, a feature often found in other libraries.

The default lookup scope has been changed from all to last, as most users are interested comparing the final results, and not intermediate results.

Related issue number

#10488

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@krfricke krfricke self-assigned this Sep 8, 2020
@krfricke krfricke requested a review from richardliaw September 8, 2020 12:15
@krfricke krfricke changed the title Tune experiment analysis [tune] Tune experiment analysis improvements Sep 8, 2020
@richardliaw richardliaw added this to the Tune/SGD 1.0 Hotlist milestone Sep 8, 2020
return best_trial

def get_best_config(self, metric=None, mode=None, scope="all"):
def get_best_config(self, metric=None, mode=None, scope="last"):
Copy link
Contributor

@richardliaw richardliaw Sep 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - need to explicitly say this on the release notes

@richardliaw
Copy link
Contributor

A couple tests failing - https://travis-ci.com/github/ray-project/ray/jobs/382378743

@krfricke
Copy link
Contributor Author

krfricke commented Sep 8, 2020

I'll fix these once the metric/mode got merged

@krfricke
Copy link
Contributor Author

krfricke commented Sep 8, 2020

Actually updated them now.

@richardliaw richardliaw marked this pull request as ready for review September 9, 2020 00:10
@richardliaw richardliaw merged commit d7c7aba into ray-project:master Sep 9, 2020
@krfricke krfricke deleted the tune-experiment-analysis branch September 9, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants