Skip to content

[tune] add mode/metric parameters to tune.run #10627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
richardliaw merged 13 commits into from
Sep 9, 2020
Merged

[tune] add mode/metric parameters to tune.run #10627

richardliaw merged 13 commits into from
Sep 9, 2020

Conversation

@krfricke
Copy link
Contributor

@krfricke krfricke commented Sep 7, 2020

Why are these changes needed?

See title. Also removes default RLLib parameter values for searchers/schedulers.

Needs full testing suite to run and maybe some example and an end-to-end test.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

Kai Fricke added 5 commits September 7, 2020 19:06
added metric and mode arguments to tune.run()
b5e10c4
Updated search algorithms
4143008
Merge branch 'master' into tune-mode-metric
5eadd6c 
# Conflicts:
#	python/ray/tune/suggest/bohb.py
#	python/ray/tune/suggest/dragonfly.py
#	python/ray/tune/suggest/nevergrad.py
#	python/ray/tune/suggest/skopt.py
#	python/ray/tune/suggest/zoopt.py
Updated seacher base class
6ba754a
lint
6a73824
@krfricke krfricke self-assigned this Sep 7, 2020
@krfricke krfricke marked this pull request as ready for review September 7, 2020 22:58
richardliaw
richardliaw approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, straightforward

@krfricke krfricke mentioned this pull request Sep 8, 2020
Merged
6 tasks
@richardliaw richardliaw added this to the Tune/SGD 1.0 Hotlist milestone Sep 8, 2020
@sumanthratna
Copy link
Member

sumanthratna commented Sep 8, 2020

we should also update the metric and mode kwargs to None for the shim functions right? #10456 #10451 (comment)

@krfricke
Copy link
Contributor Author

krfricke commented Sep 8, 2020

Absolutely. Updated the PR. Thanks for spotting this!

@richardliaw richardliaw changed the title [tune] add mode/metric parameters to tune.run, pass to search algorithms and schedulers [tune] add mode/metric parameters to tune.run Sep 9, 2020
@richardliaw richardliaw merged commit 756a9ea into ray-project:master Sep 9, 2020
@krfricke krfricke deleted the tune-mode-metric branch September 9, 2020 08:19
@krfricke krfricke restored the tune-mode-metric branch September 9, 2020 08:19
@krfricke krfricke deleted the tune-mode-metric branch September 9, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardliaw richardliaw richardliaw approved these changes

@amogkam amogkam Awaiting requested review from amogkam

Assignees

@krfricke krfricke

Labels

None yet

Projects

None yet

Milestone

Tune/SGD 1.0 Hotlist

Development

Successfully merging this pull request may close these issues.

3 participants

@krfricke @sumanthratna @richardliaw