Remove the '--include-java' option #10594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulchen
approved these changes
Sep 5, 2020
kfstorm
force-pushed
the
remove_include_java_option
branch
from
fd1eef7 to
a16580b
Compare
6 tasks
chaokunyang
reviewed
Sep 9, 2020
|
|
||
| has_java_command = False | ||
| try: | ||
| java_proc = subprocess.run( |
Member
There was a problem hiding this comment.
Will this command output be printed to console?
Member
Author
There was a problem hiding this comment.
No. subprocess.PIPE means capturing the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We can detect if Java is installed automatically.
Changes:
--include-javaoption and detect Java environment automatically.We need to disable initial workers for Java, otherwise, initial Java workers will be spawned and Python users may be confused.
Related issue number
Closes #10434
Checks
scripts/format.shto lint the changes in this PR.