Skip to content

[api] Remove legacy memory management docs#10406

Merged
ericl merged 45 commits intoray-project:masterfrom
ericl:memory-config-update
Aug 29, 2020
Merged

[api] Remove legacy memory management docs#10406
ericl merged 45 commits intoray-project:masterfrom
ericl:memory-config-update

Conversation

@ericl
Copy link
Contributor

@ericl ericl commented Aug 28, 2020

Why are these changes needed?

Some of the existing memory management documentation was out of date and mostly irrelevant now that we have distributed reference counting.

This is the third follow-up for #10325

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Aug 28, 2020
@ericl
Copy link
Contributor Author

ericl commented Aug 29, 2020

@richardliaw seems this breaks tune_sklearn:

  File "/opt/miniconda/lib/python3.6/site-packages/tune_sklearn/tune_basesearch.py", line 366, in fit
    ray.init(ignore_reinit_error=True, configure_logging=False)

Can we make it use _configure_logging instead?

@ericl ericl changed the title [api] Remove legacy memory management docs; make _enable_logging private [api] Remove legacy memory management docs Aug 29, 2020
@ericl
Copy link
Contributor Author

ericl commented Aug 29, 2020

Actually I'll just undo that bit.

@ericl ericl merged commit c14b44a into ray-project:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants